pc/modals: Disable submit buttons on when Formik isSubmitting #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssangervasi
force-pushed
the
ssangervasi/fides/2219/id-verification-multiple-submit
branch
from
0130506
to
cfa3422
Compare
ssangervasi
requested review from
chriscalhoun1974,
Kelsey-Ethyca and
LKCSmith
chriscalhoun1974
approved these changes
Jan 27, 2023
ssangervasi
force-pushed
the
ssangervasi/fides/2219/id-verification-multiple-submit
branch
from
cfa3422
to
012c371
Compare
ssangervasi
force-pushed
the
ssangervasi/fides/2219/id-verification-multiple-submit
branch
from
012c371
to
29de6ed
Compare
Codecov ReportBase: 88.55% // Head: 88.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 327 327
Lines 15714 15714
Branches 4348 4348
=======================================
Hits 13915 13915
Misses 1644 1644
Partials 155 155 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ssangervasi
deleted the
ssangervasi/fides/2219/id-verification-multiple-submit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2219
Code Changes
isSubmittingon all of these forms to prevent repeat clicksisLoadingloading state which is redundant and not implemented correctly.Steps to Confirm
/verifycall per submit.Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
I couldn't actually reproduce the error banner from the ticket - repeat clicks would send multiple requests but they would respond 200. I tried with and without
require_manual_request_approvalenabled infides.test_env.toml.But either way there's no reason to submit multiple. These modals should all have smart submit buttons.
My screen recorder shows my fast clicks as that animated circle:
https://user-images.githubusercontent.com/2236777/214980028-3bc9b69d-f1ec-403a-8683-de30d783f412.mp4
Also added the loading state:
